Fix for missing content using net4.5 zip #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forki
added a commit
that referenced
this pull request
Apr 8, 2015
Fix for missing content using net4.5 zip
|
thanks. that worked
|
|
Finally :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason the project type template worked (
Paket.Core) and the file type template (Paket tool) failed was that project type template yielded target paths (lib/net45/) with trailing slash. Trailing slashes from file type templates depends on template content.For reasons beyond my understanding, treating the nupkg as a zip file had no issues, regardless of trailing slash, but nuget would fail to extract a package if trailing slash was not present.
This PR will hopefully fix the missing content issue in #742, I have tested it on Paket and som custom templates, and it seems to work